Fix flaky tests - #337
Draft
AlistairNorman wants to merge 9 commits into
Draft
Fix flaky tests#337AlistairNorman wants to merge 9 commits into
AlistairNorman wants to merge 9 commits into
Conversation
AlistairNorman
marked this pull request as ready for review
September 2, 2026 22:49
AlistairNorman
force-pushed
the
flaky-test
branch
from
September 3, 2026 00:20
166ff78 to
d6ccc7f
Compare
AlistairNorman
changed the title
AlistairNorman
force-pushed
the
flaky-test
branch
2 times, most recently
from
September 3, 2026 00:55
6fa967f to
bfba698
Compare
AlistairNorman
marked this pull request as draft
September 3, 2026 04:28
AlistairNorman
force-pushed
the
flaky-test
branch
6 times, most recently
from
September 8, 2026 21:50
02aea6b to
6d63809
Compare
AlistairNorman
force-pushed
the
flaky-test
branch
from
September 15, 2026 21:43
abd03fb to
9bd6cfb
Compare
Chrome reports a detached node as UnknownError, which Capybara does not retry, so it failed three unrelated system specs in CI.
There were flaky tests due to Stripe requests not being specific enough with how matching worked.
This speeds up CI and means we don't have to deal with flaky tests that are being copied in from solidus storefront. Co-Authored-By: Adam Mueller <adam@super.gd>
We add Rails 8.1 and remove the unsupported Rails 7.2 and Solidus 4.5. Co-Authored-By: Adam Mueller <adam@super.gd>
Checking that we are on the correct path gives a more informative failure. Co-Authored-By: Adam Mueller <adam@super.gd>
This might be failing inconsistently leading to hard to diagnose spec failures. Co-Authored-By: Adam Mueller <adam@super.gd>
AlistairNorman
force-pushed
the
flaky-test
branch
from
September 15, 2026 21:56
9bd6cfb to
c7487e1
Compare
AlistairNorman
force-pushed
the
flaky-test
branch
from
September 16, 2026 16:36
7f7d1cb to
e1b52aa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: