[v4.6] Fix guest-token fixation in OrdersController - #49
Merged
jarednorman merged 1 commit intoSep 9, 2026
Merged
Conversation
An attacker-supplied params[:token] was written straight into the permanent signed guest_token cookie, rebinding the visitor's cart to the attacker's order and stamping the attacker's token onto future guest orders. Authorize the tokenized order view against the request token instead, and stop writing the cookie from params.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of GHSA-qj34-2493-vx9f (merged to main via the security advisory) to v4.6. Clean cherry-pick.