Skip to content

Prevent JSON 3.0 from breaking solidus_admin when using Rails 8.0 #6588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlistairNorman merged 1 commit into from
Sep 8, 2026
Merged

Prevent JSON 3.0 from breaking solidus_admin when using Rails 8.0 #6588

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions admin/solidus_admin.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,8 @@ Gem::Specification.new do |s|

s.add_dependency "blueprinter"
s.add_dependency "geared_pagination", "~> 1.1"
# Rails < 8.1 isn't compatible with json 3.x
s.add_dependency "json", "< 3"
Comment on lines 32 to +34

@benjaminwil benjaminwil Sep 8, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this change is necessary since solidus_admin depends on solidus_core.

s.add_dependency "importmap-rails", [">= 2.0", "< 3"]
s.add_dependency "solidus_backend"
s.add_dependency "solidus_core", "> 4.2"
Expand Down
1 change: 1 addition & 0 deletions core/solidus_core.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ Gem::Specification.new do |s|
s.add_dependency "discard", "~> 2.0"
s.add_dependency "friendly_id", "~> 5.0"
s.add_dependency "image_processing", "~> 1.10"
s.add_dependency "json", "< 3"
s.add_dependency "mini_magick", "~> 4.10"
s.add_dependency "monetize", "~> 1.8"
s.add_dependency "kt-paperclip", [">= 6.3", "< 8.1"]
Expand Down
Loading