Skip to content

feat: detect nub package manager#77

Open
colinhacks wants to merge 1 commit into
solidjs-community:mainfrom
colinhacks:feat/detect-nub
Open

feat: detect nub package manager#77
colinhacks wants to merge 1 commit into
solidjs-community:mainfrom
colinhacks:feat/detect-nub

Conversation

@colinhacks

Copy link
Copy Markdown

When invoked through nub, solid-cli falls through to the npm default. detectPackageManager switches on npm_config_user_agent; nub advertises nub/<version>, which isn't matched.

nub is a Rust CLI with a pnpm-compatible command grammar. This adds a nub case: runner: "nubx" (its executor) and installCommand: "add". runScriptCommand returns run ${s} rather than the bare script that pnpm and bun use — nub has no implicit script shortcut, so scripts run via nub run <script>.

Copilot AI review requested due to automatic review settings July 1, 2026 02:01

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds support for detecting the nub package manager via npm_config_user_agent, so Solid CLI generates the correct install and script-running commands when invoked through nub rather than falling back to the npm defaults.

Changes:

  • Extend detectPackageManager() to recognize npm_config_user_agent values starting with nub.
  • Define nub-specific command mappings (runner: "nubx", installCommand: "add", runScriptCommand: run <script>).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants