chore: 어드민 Vinext 배포 설정 보강#535
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Walkthrough이 변경은 API 서버 URL 검증 시점 개선, 빌드/프리뷰 환경 설정, 문서화 정비를 포함합니다.
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint skipped: no ESLint configuration detected in root package.json. To enable, add Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@codex review |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@apps/admin/package.json`:
- Line 9: The preview script in package.json uses $PWD which is shell-dependent
and can break across platforms; update the "preview" script (the preview entry
in package.json) to avoid $PWD by passing relative paths (e.g.
.vercel/output/static and .vercel/output/functions/__server.func/index.mjs) or
switch to a Node-based resolution approach (resolve with path.join in a small
Node launcher script) so the command no longer relies on shell-specific $PWD
expansion.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: d73db4e3-00d3-415c-aabb-89fe5d9a2d5a
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (8)
apps/admin/.env.exampleapps/admin/VINEXT_MIGRATION_REPORT.mdapps/admin/package.jsonapps/admin/src/components/features/auth/AdminLoginPage.tsxapps/admin/src/lib/api/auth.tsapps/admin/src/lib/api/client.tsapps/admin/src/lib/env.tsapps/admin/vitest.config.ts
| "start": "vinext start -p 4000", | ||
| "test": "vitest run", | ||
| "start": "pnpm run preview", | ||
| "preview": "srvx --prod --host 0.0.0.0 --port 4000 --static \"$PWD/.vercel/output/static\" \"$PWD/.vercel/output/functions/__server.func/index.mjs\"", |
There was a problem hiding this comment.
1) preview 스크립트의 경로 지정은 셸 의존성을 줄이는 쪽이 안전합니다.
Line 9의 $PWD는 실행 셸/플랫폼에 따라 깨질 수 있어서, 상대경로(.vercel/output/...)로 바로 넘기거나 Node 기반 경로 해석으로 통일하는 편이 더 안정적입니다.
변경 예시
- "preview": "srvx --prod --host 0.0.0.0 --port 4000 --static \"$PWD/.vercel/output/static\" \"$PWD/.vercel/output/functions/__server.func/index.mjs\"",
+ "preview": "srvx --prod --host 0.0.0.0 --port 4000 --static .vercel/output/static .vercel/output/functions/__server.func/index.mjs",📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "preview": "srvx --prod --host 0.0.0.0 --port 4000 --static \"$PWD/.vercel/output/static\" \"$PWD/.vercel/output/functions/__server.func/index.mjs\"", | |
| "preview": "srvx --prod --host 0.0.0.0 --port 4000 --static .vercel/output/static .vercel/output/functions/__server.func/index.mjs", |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@apps/admin/package.json` at line 9, The preview script in package.json uses
$PWD which is shell-dependent and can break across platforms; update the
"preview" script (the preview entry in package.json) to avoid $PWD by passing
relative paths (e.g. .vercel/output/static and
.vercel/output/functions/__server.func/index.mjs) or switch to a Node-based
resolution approach (resolve with path.join in a small Node launcher script) so
the command no longer relies on shell-specific $PWD expansion.
|
Codex Review: Didn't find any major issues. Chef's kiss. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
1 participant
관련 이슈
작업 내용
apps/admin의 Vinext production start/preview가.vercel/output산출물을 직접 실행하도록srvx기반 스크립트를 추가했습니다.VITE_API_SERVER_URL누락 시 SSR import 단계에서 500이 나지 않도록 admin API client의 환경변수 검증 시점을 요청 시점으로 늦췄습니다.vitest.config.ts를 추가하고, 테스트 파일이 없는 현재 상태에서도 test script가 성공하도록 정리했습니다..env.example과VINEXT_MIGRATION_REPORT.md에 Vercel 설정, SSR 범위, full data SSR 전환 조건을 문서화했습니다.검증
pnpm --filter @solid-connect/admin lint:checkpnpm --filter @solid-connect/admin typecheckpnpm --filter @solid-connect/admin testpnpm --filter @solid-connect/admin buildpnpm --filter @solid-connect/admin start후/,/login,/auth/login,/scores,/mentor-applications,/regions-countries,/bruno,/chat-socket, CSS asset 200 확인@solid-connect/web ci:check,@solid-connect/web build,@solid-connect/admin ci:check,@solid-connect/admin build통과특이 사항
apps/admin, Build Command는pnpm build, Output Directory는 비워두는 구성을 전제로 합니다..vercel/output은 Vercel Build Output API 경로라 별도 Output Directory로 지정하지 않습니다.리뷰 요구사항 (선택)
VITE_API_SERVER_URL누락 시 SSR import는 성공하고 실제 API 요청에서 명확한 오류가 발생하는 방향이 의도에 맞는지 확인 부탁드립니다.