Conversation
* feat: SiteUser에 homeUniversityId 컬럼 추가 - SiteUser 도메인 엔티티 수정 - Flyway 마이그레이션 스크립트 작성 * test: SiteUser에 homeUniversityId 컬럼 추가에 따른 Fixture 수정 - SiteUserFixtureBuilder 수정
* refactor: 액세스 토큰 JWT 클레임에 homeUniversityId를 추가 - generateAccessToken 메서드에 siteUser가 homeUniversityId가 null이 아니라면 claim에 추가 - parseHomeUniversityId 메서드 추가 * test: 액세스 토큰 JWT 클레임에 homeUniversityId를 추가한 것에 대한 테스트 추가 - SiteUserFixture에 국내_대학_정보_소지_사용자 메서드 추가 - AuthTokenProviderTest에 homeUniversityId 소지 여부에 따른 테스트 추가 * fix: 컨벤션 오류 리뷰 반영
유저당 멘토 승격 요청을 최대 5회까지만 가능하도록 제한
whqtker
requested review from
Gyuhyeok99,
Hexeong,
JAEHEE25,
lsy1307,
sukangpunch and
wibaek
as code owners
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
관련 이슈
작업 내용
특이 사항
최신 develop 브랜치를 기준으로 prod 릴리즈했으므로 해당 PR 머지 후 따로 배포는 안 하겠습니다.
리뷰 요구사항 (선택)