Add keyboard navigation to date picker - #890
Draft
harsha573252 wants to merge 6 commits into
Draft
Conversation
Introduces a dedicated DatePickerKeyboardService to handle open/close, arrow/page/home/end navigation, mode-aware grid movement (day/month/year), disabled-date skipping, and focus restoration on Escape. Updates the picker templates/components for roving tabindex and active-cell focusing, converts the calendar icon into an accessible toggle button with aria-expanded state, emits mode changes to keep focus in the active grid, and fixes year-grid range start calculation using floor division. Adds broad unit/spec coverage for the new keyboard and focus behavior.
Replace the two-step toggle + overlay check with a dedicated `toggleToBeDisabled` method that directly asserts the datepicker icon is disabled, simplifying the disabled state verification in form-field e2e tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces a dedicated DatePickerKeyboardService to handle open/close, arrow/page/home/end navigation, mode-aware grid movement (day/month/year), disabled-date skipping, and focus restoration on Escape. Updates the picker templates/components for roving tabindex and active-cell focusing, converts the calendar icon into an accessible toggle button with aria-expanded state, emits mode changes to keep focus in the active grid, and fixes year-grid range start calculation using floor division. Adds broad unit/spec coverage for the new keyboard and focus behavior.
Frontend Pull Request Description
Checklist
Screenshots (if applicable)
Additional Context (if necessary)