Skip to content

nui-toolbar access - #879

Open
harsha573252 wants to merge 7 commits into
solarwinds:mainfrom
harsha573252:bugfix/oo-50848/nui-toolbar-access-main
Open

nui-toolbar access#879
harsha573252 wants to merge 7 commits into
solarwinds:mainfrom
harsha573252:bugfix/oo-50848/nui-toolbar-access-main

Conversation

@harsha573252

Copy link
Copy Markdown
Contributor

(a11y): add ARIA labels, Home/End navigation, and decorative button icons

  • Added aria-label/aria-labelledby
  • Added Home & End keyboard support with tests
  • Set button icons as decorative ([decorative]="true")

Frontend Pull Request Description

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have updated change log
  • I have been following Definition of done
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new lint warnings
  • New and existing unit tests pass locally and on CI with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshots (if applicable)

Additional Context (if necessary)

@harsha573252
harsha573252 marked this pull request as ready for review June 24, 2026 14:48
@ludmilaFialova
ludmilaFialova force-pushed the bugfix/oo-50848/nui-toolbar-access-main branch from 6539f4e to afc1e3c Compare August 5, 2026 11:45
harsha573252 and others added 7 commits August 11, 2026 10:40
(a11y): add ARIA labels, Home/End navigation, and decorative button icons

- Added `aria-label`/`aria-labelledby`
- Added Home & End keyboard support with tests
- Set button icons as decorative (`[decorative]="true"`)
- Introduced `disabled` input property to `ToolbarItemComponent`.
- Updated `ToolbarKeyboardService` to skip disabled items during keyboard navigation.
- Enhanced `ToolbarComponent` to bind the disabled state to toolbar buttons.
- Added tests for aria attributes and disabled item behavior in toolbar components.
…led items and synchronizing ariaOrientation with keyboard service
@ludmilaFialova
ludmilaFialova force-pushed the bugfix/oo-50848/nui-toolbar-access-main branch from f3702b2 to 3582c60 Compare August 11, 2026 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants