feat(release): add preview build artifacts and guide to release-please PRs#16
feat(release): add preview build artifacts and guide to release-please PRs#16Palbahngmiyine wants to merge 1 commit into
Conversation
…e PRs When release-please opens or updates a release PR, build snapshot binaries for every supported OS/arch via GoReleaser, upload them as a workflow artifact, and post (or idempotently update) a Korean download/usage guide as a PR comment. Reviewers can verify the next version end-to-end before merging the release PR. - Add preview-release-pr job to .github/workflows/release-please.yml - Add comment body template at .github/templates/preview-build-comment.md.tmpl - Add snapshot.version_template to .goreleaser.yaml so the binary version matches the preview tag and resolves the v2.2 deprecation Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a markdown template for preview build comments and updates the GoReleaser configuration to include a snapshot version template. Feedback was provided to correct the Windows execution path in the documentation template, as the current command incorrectly assumes a subdirectory. Additionally, it was suggested to update the GoReleaser snapshot version template to include the short commit hash, ensuring consistency with the naming conventions used in the preview build instructions.
| Expand-Archive solactl_${VERSION}-preview-${SHORT_SHA}_windows_amd64.zip -DestinationPath . | ||
| .\solactl_${VERSION}-preview-${SHORT_SHA}_windows_amd64\solactl.exe version |
There was a problem hiding this comment.
Windows 가이드에서 Expand-Archive 명령을 -DestinationPath .와 함께 사용하면 압축 파일 내의 파일들이 현재 디렉토리에 바로 풀립니다. 현재 .goreleaser.yaml 설정상 압축 파일 내부에 별도의 디렉토리 구조(wrap_in_directory)가 없으므로, solactl.exe는 현재 위치에 생성됩니다. 따라서 하위 디렉토리 경로를 포함한 실행 명령은 실패하게 됩니다. 실행 경로를 .\solactl.exe로 수정하는 것이 좋습니다.
Expand-Archive solactl_${VERSION}-preview-${SHORT_SHA}_windows_amd64.zip -DestinationPath .
.\solactl.exe version
| name_template: checksums.txt | ||
|
|
||
| snapshot: | ||
| version_template: '{{ .Version }}' |
There was a problem hiding this comment.
snapshot.version_template을 '{{ .Version }}'으로 설정하면 GoReleaser의 기본 스냅샷 버전 규칙(보통 {{ .Tag }}-next)이 사용됩니다. 가이드 템플릿(.github/templates/preview-build-comment.md.tmpl)에서 안내하는 ${VERSION}-preview-${SHORT_SHA} 형식과 바이너리 버전 및 파일명을 일치시키려면 템플릿을 명시적으로 지정하는 것이 좋습니다.
version_template: '{{ .Version }}-preview-{{ .ShortCommit }}'
1 participant
Summary
.goreleaser.yaml의 snapshot은 v2.2의 새 키version_template로 마이그레이션하여 binary 버전이 preview 태그와 일치하게 했습니다Test plan
preview-release-prjob이 실행되는지 확인gh run download명령으로 artifact 다운로드 후solactl version실행 시solactl X.Y.Z-preview-<sha7> (commit: ..., date: ...)출력 확인release_created=true경로에서는 preview job이 skip되고 기존goreleaserjob만 동작하는지 확인🤖 Generated with Claude Code