Address leftover comments - #6
Merged
Merged
Conversation
samkim-crypto
left a comment
samkim-crypto
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me. but it would be good to get Jon's approval as well.
This PR does not update the settings to use sbpf arch v3, but this can be done after solana-program/secp256k1#18 is merged on the secp256k1 side.
Once this PR is merged, I'll play around with the current verification settings and see if we can reduce the CU consumption a bit. I'll probably do some small clean-ups in the docs as well in a follow-up.
joncinque
approved these changes
Aug 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
addressing comments in