Conversation
joncinque
reviewed
May 8, 2026
Contributor
joncinque
left a comment
There was a problem hiding this comment.
The JSON configuration feels a bit over-engineered -- how about having two separate jobs, one for core and one for alloc?
As for features, we should be able to keep the interfaces and programs simple enough that they don't need default features, which means we don't need to exclude.
What do you think?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces optional no-std package check to main action.
API
The consumer is required to have a makefile command that looks like:
And a workflow that uses
solana-program/actionsit like so:Iterated on a few different API options and found it tricky when feature excludes were global (like in solana-sdk) in combination with a separate no-alloc run. An API comparable to that would look like:
Settled on the per-package definitions.