Repository navigation
Conversation
Contributor
Test Results155 tests 155 ✅ 12s ⏱️ Results for commit f9b0afa. ♻️ This comment has been updated with latest results. |
Contributor
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IsRepeatableswitch (defaultfalse, so every existing badge, including all Task Complete badges, stays one-time).UserBadgerecord per award. Non-repeatable badges keep the existing "only once" check.UserBadges (UserId, BadgeId)index is no longer unique (the auto-incrementIdprimary key already landed in AddIdToUserBadge #441).AddIsRepeatableToBadge: addsBadges.IsRepeatable(bit, default0), then drops and recreatesIX_UserBadges_UserId_BadgeIdwithoutunique. No data is lost.For reviewers
Downrecreates the unique index, so it fails once any user holds two copies of a badge. Dedupe by hand before rolling back.Verified:
dotnet test --filter "FullyQualifiedName~AwardNewBadgesToUserTests|FullyQualifiedName~GetUserBadgesTests|FullyQualifiedName~GetBadgeByIdTests|FullyQualifiedName~EquipBadgeTests"→ 7 passed.Release note
Status: