Repository navigation
chore(release): deploy the prod backend before store review - #596
Open
LiChenyang-GZ wants to merge 5 commits into
Open
LiChenyang-GZ wants to merge 5 commits into
LiChenyang-GZ wants to merge 5 commits into
Conversation
Button 1 now deploys the API from the submitted commit (waits for approval on the prod environment) and health-checks it, so the reviewer and TestFlight use the matching backend. Button 2 (renamed Prod - Go live) only raises the minimum supported version and records the release. Adds the add-first, remove-later rule to the backend-changes, database-migrations and pr-review skills.
Contributor
Test Results148 tests 148 ✅ 9s ⏱️ Results for commit e66df55. ♻️ This comment has been updated with latest results. |
Contributor
|
… hand The minimum supported version is raised by hand in Azure, per platform, as each store goes live. Tag Release now requires the commit and reads the version from a submitted/<version> tag.
nxn-nicole
requested changes
Oct 17, 2026
nxn-nicole
left a comment
nxn-nicole
left a comment
Collaborator
There was a problem hiding this comment.
Two things to fix: which submitted/* tag to check against (backend-changes + pr-review skills), and naming LatestVersion alongside MinimumSupportedVersion in the manual release steps.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes the prod release order to backend first, then submit for review, so the store reviewer and TestFlight testers hit the backend the build was made for. 1.4.0 was rejected because the reviewer's login hit an old backend.
release-prod-app.yml): after taggingsubmitted/<version>, deploys the API from that same commit (reusesdeploy-prod-api.yml, waits for approval on theprodenvironment) and runs the/healthcheck.release-prod-backend.yml): removed. The minimum supported version is raised by hand in Azure, per platform, as each store goes live (button 2 set both at once). The release is recorded by running Tag Release on thesubmitted/<version>tag once both stores are live.backend-changes: what counts as breaking, and how to keep old + new for one releasedatabase-migrations: migrations are add-only within a releasepr-review: flag backward-compatibility breaks as majortag-release.yml: manual only now.commitis required, and the version defaults to the one in thesubmitted/<version>tag (eas.jsonat that commit still holds the previous version).Research and plan: PBI 1614 (private repo), Research comment. Plan approval from Ben still pending.
Verified: both workflow files parse as YAML.
actionlintnot run. The new order can only be proven on the next prod release (PBI acceptance criterion).Release note
Status: