Skip to content

feat: Forward system theme to Rive dashboards on Android and iOS - #264

Merged
wpmed92 merged 2 commits into
softwiredtech:mainfrom
philoh-dev:feature/forward-phone-theme-setting-rive
Oct 20, 2026
Merged

wpmed92 merged 2 commits into
softwiredtech:mainfrom
philoh-dev:feature/forward-phone-theme-setting-rive

Conversation

@philoh-dev

@philoh-dev philoh-dev commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Forward Android and iOS system appearance to Rive’s darkMode property.
  • Apply theme changes immediately, without waiting for vehicle data.
  • Prevent telemetry updates from overriding the system theme.
  • Match the loading background to the active theme.
  • Leave web-dashboard theme settings unchanged.
    Existing .riv files require no changes.

Validation

  • Swift theme-mapping regression tests passed.
  • Swift syntax and whitespace checks passed.
  • Added Android theme-mapping unit tests; not run because Java is unavailable.
  • Full app builds and device testing remain pending.

@wpmed92

wpmed92 commented Oct 20, 2026

Copy link
Copy Markdown
Contributor

@progphil1337 Thanks for the PR, i think it's pretty clean, for later to settle:
this PR now makes it so that the DashPilot settings "Dark mode" toggle won't be used in favour of the system settings. Ideally, in a later iteration, we want to change the "Dark mode" settings to something like "System, Dark, Light" for both web and Rive apps.

I have one request though for this PR to remove the unit tests, they are not wired up on iOS, and on Android they are not run on the CI. We can add unit tests once we have a better idea for exactly what to test in the app. We go manual testing for now.

@wpmed92
wpmed92 merged commit 1dcf115 into softwiredtech:main Oct 20, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants