You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
One rejected last_error can still roll back a whole batch (MySQL non-utf8mb4 charset; per-row update fallback) #141
Area:okapi-coreOutboxProcessor, both stores, MySQL schema · Follow-up to:#130 / #140
Problem
OutboxProcessor.processNext still writes every result of a batch with one updateAfterProcessingBatch call inside the claim transaction. #140 removes the two known values the database rejected in last_error: values over 64 KB on MySQL, and NUL characters on Postgres. But any other rejected value in one row still rolls back the whole batch. Entries that were already delivered go back to PENDING with retries unchanged and are redelivered on every tick.
One more cheap trigger remains on MySQL. 001__create_okapi_outbox_table.sql creates okapi_outbox without an explicit CHARACTER SET, so the table inherits the schema or server default. On a schema that is still latin1 or utf8mb3, which is common on databases from the 5.7 era or migrated ones, a last_error with an emoji or any other character outside that charset fails in strict mode with ERROR 1366 Incorrect string value. The same applies to an HTTP error body or an exception message. The whole batch then rolls back again, delivered entries included. (I haven't reproduced this yet; MySQL 8 defaults to utf8mb4, which is why the tests don't hit it.)
Options
Isolate per-row update failures (covers every cause). If the batch update throws, fall back to updating row by row. A row the database still rejects is written with a sanitized placeholder error, or skipped and left for the next tick with retries advanced, so the other rows' results survive. On Postgres this needs a savepoint per row, because an error aborts the transaction. This changes the store/processor contract, so it needs a design decision.
MySQL charset. Add DEFAULT CHARSET=utf8mb4 for new installs, plus a changeset that converts existing tables (ALTER TABLE okapi_outbox CONVERT TO CHARACTER SET utf8mb4). The conversion rebuilds the table, so the rollout notes need to cover it. A cheaper, narrower option is to convert only last_error.
Sanitize to the column charset. Replace characters the column can't store before writing. This is fragile, because the store would need to know the column charset.
Option 1 fixes the class of problem; option 2 removes the known trigger. I'd do both, starting with option 2 because it is smaller.
Tests
MySQL with a latin1 schema: a batch with one healthy entry and one whose error contains an emoji. The healthy entry stays DELIVERED.
For option 1: a store that rejects one row of a batch. The rest of the batch keeps its results, and the rejected row's retries advances.
Activity
fix(core,http): sanitize lastError so one bad value cannot poison a w…
fix(stores): review follow-up for rejected-row isolation (#141)
fix(stores): isolate a rejected row so one last_error cannot roll bac…
fix(stores): review follow-up for rejected-row isolation (#141)