Skip to content

Input params CSV unit and comment parsing [v3.13.13]#167

Merged
softwareengineerprogrammer merged 11 commits into
mainfrom
input-params-csv-unit-and-comment-parsing
Jun 6, 2026
Merged

Input params CSV unit and comment parsing [v3.13.13]#167
softwareengineerprogrammer merged 11 commits into
mainfrom
input-params-csv-unit-and-comment-parsing

Conversation

@softwareengineerprogrammer
Copy link
Copy Markdown
Owner

@softwareengineerprogrammer softwareengineerprogrammer commented Jun 5, 2026

Description

Adds parse_units_and_comments optional flag to as_csv to parse units and comments as separate columns instead of raw entry

Testing & Verification

  1. Unit tests added:
    1. test_csv_with_input_parameters_parse_units_and_comments
  2. Unit tests updated:
    1. test_csv_with_input_parameters
  3. Manual testing:
    1. Manually tested and reviewed
    2. Example CSV: https://gist.github.com/softwareengineerprogrammer/694424ec5a45a61c1c6a9ba0d2414115#file-fervo_project_cape-5_pr-167_2026-06-06-csv-L4905
    3. 🚧 Web interface CSV download

Change Checklist

Observe the following checklist items before and after merging, as applicable.

Before merging:

  1. I certify that I am a human and I have manually verified the correctness of the changes in this PR.
  2. Add a CHANGELOG entry if your change includes a new version: https://github.com/softwareengineerprogrammer/GEOPHIRES/pull/167/changes#diff-2c623f3c6a917be56c59d43279244996836262cb1e12d9d0786c9c49eef6b43cR11 (TODO to update for main repo PR once created)

After merging:

  1. 🚧 Push tag(s) to GitHub: git push origin refs/tags/v3.13.13: https://github.com/softwareengineerprogrammer/GEOPHIRES/releases/tag/v3.13.13
  2. Post a change announcement to the GEOPHIRES Change Announcements Discussion N/A too minor

Self-reviewed in #167

@softwareengineerprogrammer softwareengineerprogrammer changed the title Input params CSV unit and comment parsing Input params CSV unit and comment parsing [v3.13.13] Jun 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant