Replace manual username input with Select dropdown for student remova…#21
Open
SillyNY wants to merge 1 commit into
Open
Replace manual username input with Select dropdown for student remova…#21SillyNY wants to merge 1 commit into
SillyNY wants to merge 1 commit into
Conversation
…l The Remove Student button now shows a dropdown list of all students currently in the queue, eliminates exact username matching.
Contributor
|
Hey @SillyNY, this is great work! A few bugs small bugs I came across while testing:
And one small improvement to the Remove Student message that includes the dropdown: I'd like it to label each emoji so that the TAs can know what they mean. Something like ✅=Passoff, ❓=Question. If you make those changes, I'll go ahead and merge your PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaced the manual username text input in the "Remove Student" flow with a two-step dropdown-based interface. TAs
no longer need to type or copy/paste exact usernames.
What changed
Selectdropdown listing all students currently in the queue, with theirdisplay name, queue position, and type (help/passoff)
user_idinstead of string-matching the username — no more failed matches from typosFiles modified
ui/modals.pyRemoveConfirmModal: removed the usernameTextInput; now receivesuser_id+ displayuser_iddirectlyui/views/ta_view.pyRemoveStudentViewclass (adiscord.ui.Viewwith a dynamically populatedSelect); updated the "Remove Student" button callback to show the dropdown firstTest Plan
student is no longer in the queue." message shown
Notes
Selectsupports a maximum of 25 options. If the queue grows beyond that,entries[:25]should beused (not yet implemented — CS 240 queue sizes are typically under this limit)
Fixes: #4