Skip to content

chore: Correct the past-end priming comment - #10304

Closed
MatiPl01 wants to merge 1 commit into
mainfrom
@matipl01/android-css-priming-comment
Closed

MatiPl01 wants to merge 1 commit into
mainfrom
@matipl01/android-css-priming-comment

Conversation

@MatiPl01

Copy link
Copy Markdown
Contributor

The comment on the priming guard called the skipped write merely wasted. The real reason is visible: ObjectAnimator writes nothing until its first frame, so priming a start that is already past its end would flash the stale start value for one frame over the committed target.

@coderabbitai

coderabbitai Bot commented Aug 14, 2026 •

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 3d2c2b24-129f-44e2-8259-5aa5706e426c

📥 Commits

Reviewing files that changed from the base of the PR and between 4e0d158 and 7f331a8.

📒 Files selected for processing (1)
  • packages/react-native-reanimated/android/src/main/java/com/swmansion/reanimated/css/CSSPlatformTransitionsManager.kt

📝 Walkthrough

Summary by CodeRabbit

  • Bug Fixes
    • Prevented a brief visual flash when starting a transition after its scheduled end.
    • Transitions now skip outdated startup priming values for smoother animation behavior.

Walkthrough

The change clarifies that transitions starting after their end skip the initial property write. This prevents the committed target from being replaced by a stale start value for one frame.

Changes

CSS transition startup

Layer / File(s) Summary
Skip stale startup priming
packages/react-native-reanimated/android/src/main/java/com/swmansion/reanimated/css/CSSPlatformTransitionsManager.kt
The startup comment explains why the initial property write is skipped when a transition starts after its end.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 7f331

This is a localized documentation correction explaining an existing animation guard; it does not change product behavior, so no actionable merge-blocking risk remains.

Possibly related PRs

Suggested labels: lib: Reanimated

Suggested reviewers: pawicao

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Description check ✅ Passed The description accurately explains the comment change and the reason for skipping stale start-value priming.
Title check ✅ Passed The title clearly and concisely identifies the correction to the past-end priming comment.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch @matipl01/android-css-priming-comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@MatiPl01 MatiPl01 self-assigned this Aug 14, 2026
@MatiPl01 MatiPl01 closed this Aug 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant