Repository navigation
chore: prefix the CSS lifecycle callbacks with onCSS - #10273
Conversation
onAnimationStart and friends read as if they cover any Reanimated animation. They fire only for CSS animations and transitions, so the name says so.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (13)
📝 WalkthroughSummary by CodeRabbit
WalkthroughCSS animation and transition callback props now use ChangesCSS callback prop renaming
Estimated code review effort: 3 (Moderate) | ~20 minutes Mergeability Score: ⚪ Minimal · up to This PR renames CSS lifecycle callbacks consistently across their types, implementations, examples, and tests without changing behavior. No actionable merge-blocking risk remains beyond normal checks and review. Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
CSS lifecycle callbacks arrived inside `style`, which never worked well: functions do not survive `StyleSheet.create`, so they forced the style-array-with-inline-object shape forever, and `CSSStyle` had to `Omit` them and merge them back through `CSSConfigProps`. They are now props on the animated component, matching React DOM, which spells the same events as props. Each prop carries a JSDoc block stating what drives it, what does not, and the payload shape. The manager reads the callbacks off the props it is already handed rather than a picked-out copy, so a component update walks its props once instead of twice. Stacked on #10273, which does the rename.
Renames the eight CSS lifecycle callbacks:
onAnimationStartbecomesonCSSAnimationStart,onTransitionRunbecomesonCSSTransitionRun, and so on.