Repository navigation
Conversation
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (3)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the per-view
ObjectAnimatorengine behind Android platform CSS transitions with a single Choreographer frame callback that drives all running transitions, and batches the JS-to-UI command stream into one main-looper message per burst instead of one per transition.ObjectAnimatorfought CSS semantics in six places (delay, pre-start value writes, seek-before-start,isRunningquirks, duration scale, end-listener identity). Computing each frame from an absolute start timestamp handles delay, late starts and interruption resume directly, so all of those workarounds go away. This also stopsObjectAnimatorfrom strongly holding views (API 35+) and removes per-frame allocations in the commit-repair pass.Measured on an API 36 emulator (hardware GL, debug build, dev JS): 504 views with opacity transitions, 4 scenarios, median frame time in ms and frames drawn per 30s, mean of 3 runs. Each run used a freshly booted emulator with a checksum-verified install, and every measurement window was bracketed by health probes to reject degraded runs.
Jank under churn: 0.1-0.8% (pump) vs 4.4-4.6% (sync UI props). Pulse and stagger show similar frame counts for all engines because few views animate at any moment, so nothing is pressured into dropping frames; the differences there are in frame time.