Repository navigation
Conversation
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (3)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
MatiPl01
changed the base branch from
@matipl01/android-css-opacity-transitions
to
@matipl01/android-css-frame-pump-engine
August 3, 2026 09:22
…/android-css-transition-frame-pump # Conflicts: # packages/react-native-reanimated/android/src/main/java/com/swmansion/reanimated/css/CSSPlatformTransitionsManager.kt
…/android-css-transition-frame-pump
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the hot per-transition JNI call all-primitive. Easing curves are registered once per distinct curve (
cssDefineEasing) and referenced by id afterwards, and properties map to compile-time int ids on both sides, so starting a transition no longer allocates ajstringand twojfloatArrays per call - at heavy churn (hundreds of views re-rendering many times per second) that removed tens of thousands of transient Java objects per second from the GC.The Kotlin interpolator cache disappears with it: the interpolator is resolved once when the easing is defined and carried in the start command. The intern table is capped; an app computing easing points at runtime past the cap falls back to the loop path through the existing demotion contract, which plays any easing.
Commands now carry their
(viewTag, propertyId)key directly, so pending-command checks and the flush dispatch read as one-liners.