chore: scaffold rne-rewrite target branch (#1255)#1256
Conversation
74a6ffe to
c627eab
Compare
|
c627eab to
36f208a
Compare
|
Thanks — addressed in the latest push: 1. clang-format ✅ Brought in 2. docs ✅ (partial — want your call) Nuked 3. Branch protection |
There was a problem hiding this comment.
Personally I would prefer something more similar to: { BasedOnStyle: LLVM, UseTab: Never, IndentWidth: 4, TabWidth: 4, AllowShortIfStatementsOnASingleLine: false, IndentCaseLabels: false, ColumnLimit: 0, AccessModifierOffset: -4, FixNamespaceComments: false }. It is basically the default VS Code one, but doesn't put the { on the new line. Additionally regarding the column limit option, I find that clang formatter often makes very awkward line breaks to satisfy the column limit that often are not very readable, and it would be better to set this to no column limit and let the developers handle line breaks for very long lines. What do you think?
There was a problem hiding this comment.
Ok, so I think we can get a union of these two setups and disable fixed column limit. How about that?
|
Agreed. I will change it.
I think that ultimately we want to have some custom error types etc. So we probably want something like that, but we may think if we can add some improvements idk. I would add a separate point in aggregated issue for now, and we can eventually copy this solution in the end.
Yeap, will delete.
Yes, but there are kept in current main because it was treated as source of truth in native tests for our implementation of tokenizers. So I guess we can keep it for now and write similar tests based on them. But if you want I can delete them as well. |
36f208a to
9d6783f
Compare
Set up the base for all RNE rewrite PRs (see #1208). - Remove apps/ and the legacy packages/react-native-executorch. - Stand up the new core package by porting the rnet-poc lower-level API: cpp/core (tensor/model/dtype/install/utils), src/core, and the native bridge. MyLib -> rnexecutorch rename throughout. OpenCV and task extensions are deferred to the per-task block PRs. - Native ExecuTorch third-party binaries are NOT committed; CI is TypeScript-only and does not compile native code. They are provisioned separately before an on-device build (see third-party/README.md); wiring the on-demand mechanism is a follow-up. The common/phonemis submodule is retained for later TTS use. - Adopt the clang-format config from #1230 (.clang-format) and reformat the ported C++ sources to the LLVM-based style. - Replace the usage-oriented skills/ with the PoC's build/extend skills under .agents/skills (discoverable by AI coding agents), aligned to the rnexecutorch naming. - Remove docs/docs content (the documentation will be rewritten). - CI: drop the apps/llm native build workflows and the stale error-code verification step; run CI on the rne-rewrite branch. - GitHub meta: scope lint/typecheck/build to the core package and keep the resource-fetcher and webrtc packages on disk but excluded from CI until their surface is reworked.
9d6783f to
fc41ba4
Compare
Description
Sets up the long-lived
rne-rewritebranch that all RNE rewrite PRs will target (see #1208). Keeps the repo's yarn monorepo layout, establishes the core first, and leaves per-task functionality to follow as separate block PRs.apps/and the legacypackages/react-native-executorch.rnet-poclower-level API:cpp/core(tensor/model/dtype/install/utils),src/core, and the native bridge.MyLib→rnexecutorchrename throughout. OpenCV and task extensions are intentionally deferred to the per-task PRs.apps/llmnative build workflows and the stale error-code verification step; runs CI onrne-rewrite.*-resource-fetcherand-webrtcpackages stay on disk but are excluded from CI until their surface is reworked.Introduces a breaking change?
(Targets the
rne-rewritedev branch; the published package onmainis untouched.)Type of change
Tested on
Testing instructions
CI is TypeScript-only here (no native compile). From the repo root:
All four pass green. On-device native build is a follow-up.
Related issues
Closes #1255. Part of #1208.
Checklist
Additional notes
third-partybinaries are not committed (seepackages/react-native-executorch/third-party/README.md). CI doesn't need them; provisioning them (ideally via the repo's on-demand artifact mechanism) is a follow-up. OpenCV is dropped since CV is a later block.common/phonemissubmodule is retained (unchanged frommain) for later use by the TTS block.scripts/generate-errors.tsstays dormant for later reintroduction.tokenizers-cpp,googletest) are left in place for likely reuse by the LLM block; they aren't checked out in CI.react-native-workletsemits peer-dep warnings (@babel/core,@react-native/metro-config) — harmless app-integration peers, not needed to build the lib.