fix(ios): initialize surface props in BottomSheetSurfaceComponentView - #72
Open
JaMinsane wants to merge 1 commit into
Open
Conversation
JaMinsane
marked this pull request as ready for review
August 17, 2026 00:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Fabric requires every
RCTViewComponentViewsubclass to initialize_propswith its concrete default props.BottomSheetComponentViewalready follows this contract, butBottomSheetSurfaceComponentViewdid not. In an iOS debug build using React Native 0.87.0, mountingBottomSheetSurfaceViewfor a non-nullsurfacetherefore triggered the following assertion:This caused a
ModalBottomSheetto terminate the application before becoming visible.Fix
This PR imports the generated props header and initializes
_propswithBottomSheetSurfaceViewPropsininitWithFrame:.This matches the existing implementation in
BottomSheetComponentViewand satisfies the Fabric component-view contract.There are no JavaScript API or Android behavior changes.
Verification
ModalBottomSheetopens without the native exception.BottomSheetSurfaceViewPropsmatches the component descriptor used byBottomSheetSurfaceComponentView.