Skip to content
This repository was archived by the owner on Aug 24, 2019. It is now read-only.

fixed deprecated call in drawRect:#2

Open
Zhukn1 wants to merge 3 commits into
soffes:masterfrom
Zhukn1:drawRect-fix
Open

fixed deprecated call in drawRect:#2
Zhukn1 wants to merge 3 commits into
soffes:masterfrom
Zhukn1:drawRect-fix

Conversation

@Zhukn1

@Zhukn1 Zhukn1 commented Sep 30, 2013

Copy link
Copy Markdown

The call drawInRect:withFont:lineBreakMode:alignment: is deprecated in iOS 7 and needs to be switched to drawInRect:withAttributes:

@soffes

soffes commented Nov 29, 2013

Copy link
Copy Markdown
Owner

Thanks for this! The check seems a bit heavy though. You could just see if the first character is 7 or higher. I'll think on it.

@marcelofabri

Copy link
Copy Markdown

Isn't it better to check if [_placeholder respondsToSelector:@sel(drawInRect:withAttributes:)?

@soffes

soffes commented Dec 2, 2013

Copy link
Copy Markdown
Owner

@marcelofabri good call!

@Zhukn1

Zhukn1 commented Dec 2, 2013

Copy link
Copy Markdown
Author

kinda awkward that I didn't do that from the start:) thanks, @marcelofabri!

@soffes

soffes commented Dec 2, 2013

Copy link
Copy Markdown
Owner

Can you merge master into your branch? Thanks!

@Zhukn1

Zhukn1 commented Dec 3, 2013

Copy link
Copy Markdown
Author

@soffes done.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants