Skip to content

Fix baseline CI failures - #2

Merged
samuel-williams-shopify merged 2 commits into
mainfrom
fix-main-test-expectations
Aug 20, 2026
Merged

Fix baseline CI failures#2
samuel-williams-shopify merged 2 commits into
mainfrom
fix-main-test-expectations

Conversation

@samuel-williams-shopify

@samuel-williams-shopify samuel-williams-shopify commented Aug 20, 2026

Copy link
Copy Markdown

Summary

  • raise the CMake minimum from 3.0 to 3.5 so current CMake 4 runners can configure the project
  • update standalone inline-node rendering assertions to expect no trailing newline
  • update CommonMark example 617 to reflect support for XML namespace prefixes in HTML tag names
  • avoid an MSVC warnings-as-errors failure caused by shadowing the existing info variable in front matter rendering

These failures are already present on main and are unrelated to the inline-code-info feature.

Validation

  • cmake -S . -B build-main-fix -DCMARK_SHARED=ON -DCMARK_STATIC=ON
  • cmake --build build-main-fix --parallel
  • ctest --test-dir build-main-fix --output-on-failure

All 13 CTest targets pass locally with CMake 4.1.1.

Assisted-By: devx/c76f68ef-c5ab-4096-b170-fc6974ad760d
Assisted-By: devx/c76f68ef-c5ab-4096-b170-fc6974ad760d
@samuel-williams-shopify
samuel-williams-shopify merged commit ede48b0 into main Aug 20, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant