Close persistent proxy clients in dependency order - #63
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A CONNECT tunnel remains an active request on the proxy client until the tunnelled client closes.
Client#closewaits for active requests to drain, butPersistentClientsinserted the proxy client before the tunnelled client and then closed in insertion order. That made shutdown wait on the CONNECT request before closing the client that could finish it.This addresses the deterministic persistent-client shutdown deadlock isolated while investigating #59.
Verification
Async::TimeoutErrorinAsync::Pool::Controller#wait_until_freebundle exec sus— 28 examples, 138 assertionsbundle exec rubocop lib/async/http/faraday/clients.rb test/async/http/faraday/clients.rb