NO-SNOW: stop relying on connector threads in pandas CTE test - #4324
Merged
Conversation
Daily Snowpark pandas CI failed because create_dataframe no longer leaves a background thread on Linux/macOS. Spawn a dummy thread so the warning-filter assertion is deterministic.
sfc-gh-bkogan
commented
Aug 20, 2026
sfc-gh-bkogan
left a comment
sfc-gh-bkogan
left a comment
Collaborator
Author
There was a problem hiding this comment.
SHIP WITH NITS
Correct, test-only change that decouples the multithreading-warning trigger from connector internals and is more reliable than the old create_dataframe dependency. The suppression path is still genuinely exercised because the probe thread guarantees active_count() > 1 at the moment cte_optimization_enabled flips to True. A few optional robustness nits are inline.
…thread join Address review nits: add a positive control for the multithreading warning, drop the redundant daemon flag, and fail if the probe thread does not stop.
sfc-gh-bkogan
added
the
NO-CHANGELOG-UPDATES
sfc-gh-bkogan
marked this pull request as ready for review
August 20, 2026 18:06
sfc-gh-bkogan
requested review from
sfc-gh-aling,
sfc-gh-yixie and
sfc-gh-yuwang
August 20, 2026 18:06
![snowflake-security-bot[bot]](https://avatars.githubusercontent.com/u/140554735?s=60&v=4){kind=small}
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4324 +/- ##
==========================================
+ Coverage 95.24% 95.46% +0.22%
==========================================
Files 171 171
Lines 44720 44720
Branches 7676 7676
==========================================
+ Hits 42593 42694 +101
+ Misses 1340 1253 -87
+ Partials 787 773 -14 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
sfc-gh-mayliu
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_cte_optimization_for_snowpark_pandas) has been failing on Linux/macOS since ~Aug 12 becausecreate_dataframeno longer leaves a connector background thread around.warn_session_config_update_in_multithreaded_modewould fire; it now starts a dummy thread instead of depending on connector internals.Test plan
pytest tests/integ/modin/test_session_cte_optimization.py::test_cte_optimization_for_snowpark_pandaslocally in thesnowflakeconda env (passed)