SNOW-2912540: define ASYNC_RETRY_PATTERN and compat.OK locally - #4282
Open
sfc-gh-fpawlowski wants to merge 6 commits into
Open
SNOW-2912540: define ASYNC_RETRY_PATTERN and compat.OK locally#4282sfc-gh-fpawlowski wants to merge 6 commits into
sfc-gh-fpawlowski wants to merge 6 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## create-temp-table-ast-fix-on-main #4282 +/- ##
====================================================================
Coverage ? 95.46%
====================================================================
Files ? 171
Lines ? 44719
Branches ? 7676
====================================================================
Hits ? 42693
Misses ? 1253
Partials ? 773 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
sfc-gh-fpawlowski
marked this pull request as ready for review
July 22, 2026 16:45
sfc-gh-fpawlowski
requested review from
sfc-gh-bkogan,
sfc-gh-mayliu and
sfc-gh-yixie
July 22, 2026 16:45
4 tasks
sfc-gh-fpawlowski
force-pushed
the
SNOW-2912540-remove-connector-shims
branch
from
August 6, 2026 09:09
42128db to
a87e53a
Compare
sfc-gh-fpawlowski
changed the base branch from
main
to
create-temp-table-ast-fix-on-main
August 6, 2026 09:10
![snowflake-security-bot[bot]](https://avatars.githubusercontent.com/u/140554735?s=60&v=4){kind=small}
6 tasks
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Aug 6, 2026
3 tasks
sfc-gh-fpawlowski
force-pushed
the
SNOW-2912540-remove-connector-shims
branch
from
August 20, 2026 16:27
b14c893 to
74db794
Compare
sfc-gh-fpawlowski
force-pushed
the
create-temp-table-ast-fix-on-main
branch
from
August 20, 2026 16:27
ff905f3 to
0ce0042
Compare
sfc-gh-aling
approved these changes
Aug 20, 2026
…ncoding The deprecated `create_temp_table` parameter was being emitted to the proto AST as a separate boolean field even though the runtime already translates it to `table_type="temporary"`. This meant the AST decoder had to handle two representations for the same thing. Fix: move the deprecation coercion before the AST block in save_as_table so `table_type` is already resolved when emitted; remove the deprecated field from both AST emission sites (WriteTable and WritePandas); update the internal cache_result mock path to pass table_type="temp" directly; mark the proto fields as deprecated. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
These constants were previously imported from snowflake-connector-python. The Universal Driver connector no longer owns them (it has no internal use for either symbol), so define them locally to remove the coupling. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
The Universal Driver connector's constants module won't provide ENV_VAR_PARTNER either (per review discussion on snowflake-eng/universal-driver#512), so define it locally in server_connection.py alongside the other now-local backward compatibility constants (ASYNC_RETRY_PATTERN, compat.OK). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
sfc-gh-fpawlowski
force-pushed
the
create-temp-table-ast-fix-on-main
branch
from
August 21, 2026 08:24
d9de3cb to
4d80196
Compare
sfc-gh-fpawlowski
force-pushed
the
SNOW-2912540-remove-connector-shims
branch
from
August 21, 2026 08:24
a592c7d to
b245fcd
Compare
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes two imports from snowflake-connector-python that the Universal Driver connector no longer provides as shims.
async_job.py:ASYNC_RETRY_PATTERNdefined locally (was imported fromconnector.cursor)mock/_telemetry.py:from http.client import OK(was imported fromconnector.compat)Companion changes in snowflake-eng/universal-driver PR #512 and #513.
Checklist
Stack (via Graphite)
🤖 Generated with Claude Code