Skip to content

Make JsonTreeElement immutable and reduce keys in remembers #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
snappdevelopment merged 1 commit into from
Aug 16, 2026
Merged

Make JsonTreeElement immutable and reduce keys in remembers #183

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions jsontree/src/commonMain/kotlin/com/sebastianneubauer/jsontree/JsonTreeElement.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
package com.sebastianneubauer.jsontree

import androidx.compose.runtime.Immutable

@Immutable
internal sealed interface JsonTreeElement {
val id: String
val level: Int
Expand All @@ -19,6 +22,7 @@ internal sealed interface JsonTreeElement {
enum class Type { STRING, BOOLEAN, NUMBER, OTHER }
}

@Immutable
sealed interface Collapsable : JsonTreeElement {
val state: TreeState
val children: Map<String, JsonTreeElement>
Expand Down
8 changes: 0 additions & 8 deletions jsontree/src/commonMain/kotlin/com/sebastianneubauer/jsontree/util/AnnotatedText.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,12 +33,8 @@ internal fun rememberCollapsableText(
val itemCount = pluralStringResource(Res.plurals.jsontree_collapsable_items, childItemCount, childItemCount)

return remember(
key,
state,
colors,
isLastItem,
itemCount,
type,
showIndices,
showItemCount,
searchOccurrence,
Expand Down Expand Up @@ -120,11 +116,7 @@ internal fun rememberPrimitiveText(
parentType: ParentType,
): AnnotatedString {
return remember(
key,
value,
colors,
type,
isLastItem,
showIndices,
searchOccurrence,
searchOccurrenceSelectedRange
Expand Down