refactor: rename Minter to GitHubApp - #111
Merged
Merged
Conversation
The struct is the server-side GitHub App client, not an abstract 'minter': github/minter.rs becomes github/app.rs, the state field becomes github_app, and mint/mint_for_remote become token_for/token_for_remote. Also refreshes the module docs, which still described the tokens and reverse proxy as read-only from before the push path existed. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renames the GitHub App token component after what it is rather than one verb it performs:
github/minter.rs→github/app.rs,Minter→GitHubAppAppState.minter→AppState.github_app;GitProxy.minter→GitProxy.appmint/mint_for_remote→token_for/token_for_remoteAlso corrects the
githubmodule docs, which still described the tokens and the reverse proxy as read-only from before the push path existed.No behavior change; all tests pass.
🤖 Generated with Claude Code
Note
Low Risk
Pure rename and documentation fixes with no logic changes; risk is limited to missed call sites, which grep shows are fully migrated.
Overview
This is a naming-only refactor of the control plane’s GitHub App integration so types and methods describe the component, not a single action.
Server:
github/minter.rsbecomesgithub/app.rs.MinterisGitHubApp;AppState.minterisgithub_app;GitProxyholdsappinstead ofminter. Public mint APIs are renamed totoken_for/token_for_remote(call sites inservice,git_proxy, andmainfollow).Docs/comments: References to “minter” are updated in
CLAUDE.md,devbox-agent,devbox-common, and server modules. Thegithubmodule docs now state the reverse proxy handles fetch and push (push gated on a claimed box), correcting stale “read-only” wording.No API or auth behavior changes; tests were updated for the new names (e.g.
mint_git_token_without_github_app_is_service_unavailable).Reviewed by Cursor Bugbot for commit d48c41b. Bugbot is set up for automated code reviews on this repo. Configure here.