Conversation
jterapin
marked this pull request as ready for review
October 2, 2026 03:53
jterapin
force-pushed
the
fix-sparse-deserialization
branch
from
October 2, 2026 20:37
1b1cc6a to
7c59e39
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Non-sparse collections must not contain null values, but the JSON and CBOR deserializers silently discard them.
Fix
Raise the codec-specific
ParseErrorfor null values in non-sparse collections while continuing to retain null values in collections marked with@sparse.Testing
1,240 examples, 0 failures, and 2 existing pending examples using Ruby 4.0.4.
🤖 This PR description was drafted with AI assistance and reviewed by @jterapin. ✨