Migrate to JMeter 5.6 multi-stage build with RMI SSL and CI - #1
Merged
Conversation
Consolidate base and worker images into one Dockerfile on Eclipse Temurin 21, verify Apache archives with sha512, install jp@gc plugins at build time, and add a worker entrypoint that runs jmeter-server with LOCALIP.
Fetch both from Maven Central (immutable, versioned) instead of the rolling jmeter-plugins.org/get/ "latest" endpoint, so each jar can be SHA512-verified at build time like the JMeter archive.
Define both image targets once with JMETER_VERSION centralized per file, and add a GitHub Actions matrix that builds each target and smoke-checks JMeter.
Enable authenticated, encrypted distributed testing when a shared keystore is mounted via RMI_KEYSTORE. SSL settings are written to a 0600 properties file so the keystore password never appears in the process list. Without a keystore the engine runs plaintext as before, now with an explicit warning.
JMETER_HOME and PATH were set in one ENV, so ${JMETER_HOME} resolved to its
empty pre-instruction value and the JMeter bin dir never reached PATH. Bare
`jmeter` (used by the CI smoke check) failed with "not found".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The images were stuck on JMeter 3.2 with hand-maintained master/slave Dockerfiles, an unpinned plugin download, and no automated build. This brings the project to JMeter 5.6.3 with a reproducible, verifiable build and optional transport security for distributed runs.
Approach
A single multi-stage
Dockerfileproduces a sharedjmeter-base(controller) and ajmeter-workerthat builds on it, so both always carry the same JMeter and plugin set. Build inputs are pinned and checksummed, the version lives in one place per file, and a CI matrix builds both targets on every push/PR. Distributed RMI can optionally be authenticated and encrypted without changing the default plaintext behavior for trusted networks.How it works
jmeter-plugins.org/get/endpoint.docker-compose.ymlanddocker-bake.hcldefine both targets withJMETER_VERSIONcentralized; a GitHub Actions matrix builds each target and smoke-checksjmeter --version.RMI_KEYSTOREturns on authenticated, encrypted distributed testing. SSL settings are written to a0600properties file so the password never appears in the process list; without a keystore the worker runs plaintext as before, now with an explicit startup warning.test.jmxis updated to the 5.6.3 plan format.