fix: tooltip in tbl new approach#2880
Merged
Merged
Conversation
zammarchi-smeup
requested review from
Leonardo-Signorelli,
lucafoscili and
pasere-smeup
as code owners
lucafoscili
approved these changes
Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR solves the issue for a tooltip in an input panel TBL cell
The approach is simplier and more correct than the previous attempt, that broke webupjs build
Tests on the INP and the Tooltip on webupjs pass correctly with these changes
The logic here leverages the props of the event emitted by the datatable, since it contains the cell.
When at line 2314 the cell is not found in the rows of the input panel (it will never happen since the column passed is a column of the data table and not of the INP) the cell passed in the props of the event is used, cell corresponding to the right clicked cell of the data table.
When the TBL is used inside an input panel (InputLegacy) the columns of the INP and the TBL will ALWAYS have different names, because otherwise the rpg code would not compile