Use column metadata in cell type detection#2877
Merged
Merged
Conversation
Updated `dom.ketchup.data.cell.getType` to accept the column along with the cell, and propagated the new signature across data table, form, input panel, and f-cell call sites. Type inference now also considers `column.maxLength` (with cell-level override) when deciding MEMO vs STRING, and `maxLength` was added to `KupDataColumn` to support this metadata.
stefanolanari
requested review from
Leonardo-Signorelli,
lucafoscili and
pasere-smeup
as code owners
lucafoscili
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated
dom.ketchup.data.cell.getTypeto accept the column along with the cell, and propagated the new signature across data table, form, input panel, and f-cell call sites. Type inference now also considerscolumn.maxLength(with cell-level override) when deciding MEMO vs STRING, andmaxLengthwas added toKupDataColumnto support this metadata.