11.0.7#2875
Merged
Merged
Conversation
Bind KupBox click handler to the instance to avoid repeated binds. Overhaul KupDataTable focus and cell lookup: add #lastFocusedCellElement, use data-row-id attributes, and introduce helpers (#getRowFromElement, #getCellFromElement, #getFCellProps, #getRenderedCellElement) to resolve rows/cells from DOM elements. Persist/restore last focused cell element after render, update horizontal/vertical navigation to use the element reference, and set kup-get-cell-props to use a provided getCellProps closure. Update FCell declarations to accept getCellProps and FCell implementation to call it; improve input value extraction with getInputValueFromEvent and use that in events. Remove reliance on serialized data-cell objects in DOM and switch to dataset-based lookups. In KupTheme, add optional support for Constructable StyleSheets: cache shared sheets, adopt them into component shadow roots for supported tags, update shared sheets on theme changes, and refactor style composition (introduce getSharedStyle and updated setKupStyle) to use the new mechanism when available.
LS26001825: kup-data-table editable: fix show error message ongli on "data" change
Compute and persist the first editable cell that contains an error and focus it after render, instead of scanning paginated rows each render. Added a @watch('data') checkFocusErrorCell() that sets a new private field #cellToFocus when data/columns change, declared #cellToFocus, and updated the render flow to consume and clear that value (calling setFocus).
Expanded the KupTheme.adoptedStyleSheetsTargets set to include a large list of KUP custom elements (e.g. KUP-ACCORDION, KUP-BUTTON, KUP-CARD, KUP-DATA-TABLE, KUP-FORM, KUP-IMAGE, KUP-TREE, etc.). This allows the manager to apply shared CSS via adoptedStyleSheets to these components' shadow roots, ensuring consistent theming across more components.
Add hasManagedComponentForTag to check if any managed component with the given tag is currently connected and using adoptedStyleSheetsTargets. When supportsConstructable is true, remove the tag's entry from sharedSheets after a component is detached if no other managed component remains. This cleans up unused constructable stylesheets for tags when the last managed component is disconnected.
Ensure dynamic-position listeners and detached overlays are fully cleaned up when components disconnect or unregister. This also tracks attached scroll targets so teardown can reliably remove the exact listeners that were added.
lucafoscili
requested review from
Leonardo-Signorelli and
pasere-smeup
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.