Skip to content

LS26001825: kup-data-table editable: fix show error message ongli on "data" change#2869

Merged
lucafoscili merged 1 commit into
developfrom
fix-show-message
Jun 17, 2026
Merged

LS26001825: kup-data-table editable: fix show error message ongli on "data" change#2869
lucafoscili merged 1 commit into
developfrom
fix-show-message

Conversation

@pasere-smeup

Copy link
Copy Markdown
Collaborator

This pull request enhances error handling and user feedback in the kup-data-table component, particularly for errors present in hidden columns. The main changes include introducing a new callback prop for custom error message display, refactoring error detection logic, and updating documentation.

Error handling improvements:

  • Added a new showMessage callback prop to the kup-data-table component, allowing consumers to provide a custom function for displaying error messages (such as errors in hidden columns), and updated the documentation to describe this prop (readme.md).
  • Refactored the logic for detecting errors in hidden columns: extracted this check into a new checkHiddenColumnErrors method, which is triggered when the data property changes. If errors are found in hidden columns, the showMessage callback is invoked (kup-data-table.tsx).

Code simplification:

  • Removed the previous logic that handled hidden column errors within the cell focus loop, delegating this responsibility to the new watcher method for better separation of concerns and code clarity (kup-data-table.tsx).

@lucafoscili lucafoscili merged commit 29d407e into develop Jun 17, 2026
1 check passed
@pasere-smeup pasere-smeup deleted the fix-show-message branch June 17, 2026 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants