Repository navigation
CLI: tsk edit --thread and --clear-thread - #308
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Owner
Author
Review panel · review
|
Merged
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A thread could only be set when a task was created. Fixing it meant re-adding the task, which lost its number, steps and paper trail. The domain edit already carried the thread; only the CLI flag was missing.
What changed
tsk edit <task> --thread <name>sets or changes the thread (same name rules and refusal astsk add --thread).--clear-threadclears it, matching edit's--clear-base/--clear-due/--clear-after.cli.mdedit section,CONTEXT.md,llms.txt, CHANGELOG (Unreleased · Added).tsk-cliskill: its refine rule saideditcannot change the thread. Rewritten, and both skills bumped 1.7.0 → 1.8.0 (the first skill edit since v0.14.0), with hash pins refreshed.Scope
Done when
--threadsets a thread on a task that has none;tsk list T1shows#auth; paper trail records a thread editcli_edit::edit_sets_changes_and_clears_the_thread_keeping_scope--threadchanges a set thread;--clear-threadclears it; scope unchanged--threadwith--clear-threadexit 2 without writing; a repeat writes nothingparser::tests::edit_parses_thread_flags_by_the_thread_rulescli_edit::edit_help_names_title_notes_and_equals_forms,setup_agenthash pinsVerification
Commit: c75907f (steps 1-3 rerun here; step 4 ran on 044403f, and the follow-up commit changes only help text, the skill, the hash pins and the test)
cargo fmt --check && cargo clippy --all-targets -- -D warnings && cargo test→ exit 0, every suitetest result: ok.cd site && npm run build && npm test→ 64 pass, 0 fail.next_threadreverted tofound.threadinsrc/cli/edit.rs, the new integration test fails (left: None, right: Some("auth")); restored, it passes. The repeat check comparestsk.jsonbytes. With the no-change return disabled and the domain edit forced, it fails (a repeat writes nothing).TSK_STATE_DIR(debug binary of this commit):Run any smoke with
TSK_STATE_DIRset to a throwaway dir.Could break
Only
tsk editparsing and the edit path. With no thread flag the stored thread passes through as before.tsk add's thread parsing now shares the same helper, with identical messages.For the owner to decide
The flag spelling:
--clear-threadmatches edit's other--clear-*flags.tsk listuses--no-threadas a filter.