fix(cubejs): retry Arrow without compression SET on readonly ClickHouse - #85
Open
akshaykumar2505 wants to merge 2 commits into
Open
akshaykumar2505 wants to merge 2 commits into
akshaykumar2505 wants to merge 2 commits into
Conversation
Native ArrowStream set output_format_arrow_compression_method=none. Readonly cube users cannot SET that, so dashboard format=arrow loads 500ed. Retry the same query without the override.
The wrapped Cube driver has no ClickHouse exec client, so native ArrowStream threw TypeError. Catch that and stream semantic Arrow so format=arrow still succeeds for readonly cubes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
output_format_arrow_compression_method=none.format=arrowloads 500ed.Test plan
node --test src/utils/__tests__/clickhouseArrow.test.js test/loadExport.test.jsPOST /api/v1/loadwithformat=arrowon a readonly ClickHouse cube returns 200