Chore: Use checkpoint 299_000_000 as a final fallback instead of 0 - #480
Open
faisal-chainlink wants to merge 4 commits into
Open
Chore: Use checkpoint 299_000_000 as a final fallback instead of 0#480faisal-chainlink wants to merge 4 commits into
faisal-chainlink wants to merge 4 commits into
Conversation
|
👋 faisal-chainlink, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Use the value of 299_000_000 as a last resort fallback instead of 0 for the checkpoint starting sequence.
The scenario is unexpected to happen as it assumes an RPC failure for getting the latest checkpoint as well as a missing node config. We also use
clampToProviderFloorto get the RPC's lowest available checkpoint as most RPCs are pruned.This fallback would gracefully use the value above instead of 0 if the RPC is a full-archive node and the configs are missing.
Issue ticket number and link
Describe highly relevant files or code snippets that are critical in the review
Are there other PRs that should be merged first?