fix lock release rebalancer cap function - #471
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes mcms_destroy_rebalancer_cap in the Lock/Release token pool so MCMS can renounce rebalancer control by clearing the active rebalancer_cap_id before deleting the MCMS-held RebalancerCap, leaving the pool with no active rebalancer.
Changes:
- Update
mcms_destroy_rebalancer_capto clearstate.rebalancer_cap_id(to the zero sentinel) before deleting the MCMS-held rebalancer cap. - Add a
#[test_only]helper to check whether the MCMS cap currently contains a rebalancer cap. - Add tests covering successful cap destruction, failure when no cap exists, and re-taking rebalancer control after destruction.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
contracts/ccip/ccip_token_pools/lock_release_token_pool/sources/lock_release_token_pool.move |
Adjusts MCMS rebalancer-cap destruction flow to clear active rebalancer ID before deleting the cap; adds a test-only helper. |
contracts/ccip/ccip_token_pools/lock_release_token_pool/tests/lock_release_token_pool_mcms_cap_test.move |
Adds encoding helper + new tests for destroying and re-taking MCMS rebalancer control. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+693
to
+694
| let RebalancerCap<T> { id } = rebalancer_cap; | ||
| object::delete(id); |
…ainlink-sui into rebalancer-cap
JohnChangUK
approved these changes
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Issue ticket number and link
Describe highly relevant files or code snippets that are critical in the review
Are there other PRs that should be merged first?