Skip to content

NONEVM-5256: MCMS cap object transfer fix #409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
FelixFan1992 wants to merge 6 commits into
base: develop
Choose a base branch
from
Draft

NONEVM-5256: MCMS cap object transfer fix #409

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
434549c
NONEVM-5256: MCMS cap object transfer fix
FelixFan1992 Jun 15, 2026
0419c47
revert
FelixFan1992 Jun 15, 2026
b242715
fix
FelixFan1992 Jun 15, 2026
5d48072
Merge branch 'develop' into nonevm-5256
FelixFan1992 Jun 16, 2026
6ed457d
update all packages
FelixFan1992 Jun 16, 2026
1fb1397
Merge branch 'develop' into nonevm-5256
FelixFan1992 Jun 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
81 changes: 80 additions & 1 deletion bindings/generated/mcms/mcms_deployer/mcms_deployer.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

14 changes: 10 additions & 4 deletions contracts/ccip/ccip/Move.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,24 +5,30 @@
version = 4

[pinned.testnet.MoveStdlib]
source = { git = "https://github.com/MystenLabs/sui.git", subdir = "crates/sui-framework/packages/move-stdlib", rev = "384b1c7ff289b32ed2664f29dc47dbc879fa43ee" }
source = { git = "https://github.com/MystenLabs/sui.git", subdir = "crates/sui-framework/packages/move-stdlib", rev = "718ae563a42fb4ba0d055588f81c704dcef58c25" }
use_environment = "testnet"
manifest_digest = "C4FE4C91DE74CBF223B2E380AE40F592177D21870DC2D7EB6227D2D694E05363"
deps = {}

[pinned.testnet.Sui]
source = { git = "https://github.com/MystenLabs/sui.git", subdir = "crates/sui-framework/packages/sui-framework", rev = "384b1c7ff289b32ed2664f29dc47dbc879fa43ee" }
source = { git = "https://github.com/MystenLabs/sui.git", subdir = "crates/sui-framework/packages/sui-framework", rev = "718ae563a42fb4ba0d055588f81c704dcef58c25" }
use_environment = "testnet"
manifest_digest = "7AFB66695545775FBFBB2D3078ADFD084244D5002392E837FDE21D9EA1C6D01C"
deps = { MoveStdlib = "MoveStdlib" }

[pinned.testnet.ccip]
source = { root = true }
use_environment = "testnet"
manifest_digest = "B41543A1928002B1ABE6F16D69A3C1BE6BCA4D7A4DB7D2F9048274EFE11ED724"
deps = { mcms = "mcms", std = "MoveStdlib", sui = "Sui" }
manifest_digest = "E5912E2FA12F49E878734EC73B1CAC461C88F1562C6C02B940082B986AE865FE"
deps = { fast_mcms = "mcms", mcms = "mcms_1", std = "MoveStdlib", sui = "Sui" }

[pinned.testnet.mcms]
source = { local = "../../mcms/fast_mcms" }
use_environment = "testnet"
manifest_digest = "5745706258F61D6CE210904B3E6AE87A73CE9D31A6F93BE4718C442529332A87"
deps = { std = "MoveStdlib", sui = "Sui" }

[pinned.testnet.mcms_1]
source = { local = "../../mcms/mcms" }
use_environment = "testnet"
manifest_digest = "5745706258F61D6CE210904B3E6AE87A73CE9D31A6F93BE4718C442529332A87"
Expand Down
7 changes: 4 additions & 3 deletions contracts/ccip/ccip/sources/state_object.move
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,17 +347,18 @@ public fun mcms_execute_ownership_transfer(
let package_address = bcs_stream::deserialize_address(&mut stream);
bcs_stream::assert_is_consumed(&stream);

let owner_cap = mcms_registry::release_cap(registry, McmsCallback {});

if (mcms_deployer::has_upgrade_cap(deployer_state, package_address)) {
let upgrade_cap = mcms_deployer::release_upgrade_cap(
let upgrade_cap = mcms_deployer::release_upgrade_cap_at(
deployer_state,
registry,
package_address,
McmsCallback {},
);
transfer::public_transfer(upgrade_cap, to);
};

let owner_cap = mcms_registry::release_cap(registry, McmsCallback {});

execute_ownership_transfer(ref, owner_cap, to, ctx);
}

Expand Down
Loading
Loading