Skip to content

Rm TODO that would add too much complexity for not enough gain #703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ilija42 merged 1 commit into from
Jul 29, 2026
Merged

Rm TODO that would add too much complexity for not enough gain #703

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions chain_capabilities/stellar/actions/write_report.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,11 +124,6 @@ func (wr *writeReport) execute(

txHashRetriever := NewTxHashRetriever(wr.forwarderClient, wr.lggr, transmissionID)

// TODO(follow-up): Consider simulating the on_report transaction before polling when the
// transmission has not yet been attempted. If simulation predicts a terminal failure we
// could skip delta-stage polling and/or submission. Open questions: simulation may fail on
// only some DON nodes (stale ledger, timing), so every node must still return the same
// WriteReportReply and metering semantics before enabling this shortcut.
info, err := wr.pollTransmissionInfo(ctx, request, telemetryContext, transmissionID, queuePosition)
if err != nil {
return nil, capabilities.ResponseMetadata{}, fmt.Errorf("failed to get transmission info: %w", err)
Expand Down
Loading