Avoid invalid climate state when power sensor turns on#1563
Open
naamah75 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a configured
power_sensorchanges toonwhile the climate entity is currently off, SmartIR restores the last HVAC mode when available. If there is no last operation yet, it currently falls back toSTATE_ON.For a Home Assistant climate entity,
onis not a supported HVAC mode/state. This can produce warnings/errors in consumers that validate climate states, for example Alexa:This changes the fallback to use the first configured non-off HVAC mode when available, otherwise it stays
off. That keeps the climate entity state within the supported HVAC modes.Tested with: