fix(server): initialize prometheus headers map to avoid nil map panic#820
Open
SAY-5 wants to merge 1 commit into
Open
fix(server): initialize prometheus headers map to avoid nil map panic#820SAY-5 wants to merge 1 commit into
SAY-5 wants to merge 1 commit into
Conversation
The server command's --prometheus-header flag panicked with "assignment to entry in nil map" because the backing map was never initialized, unlike the equivalent --extra-labels flag in other commands. Initialize it in NewServerCommand and add a regression test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #819.
sloth server --prometheus-header='k=v'panicked withassignment to entry in nil mapbecauseserverCommand.prometheus.headerswas passed toStringMapVarwhile still nil. The equivalent--extra-labelsflag ingenerate/validate/k8scontrollerworks because those commands initialize the map (&generateCommand{extraLabels: map[string]string{}});serverdid not.Initializes the map in
NewServerCommandand adds a regression test that parsesserver --prometheus-header=...and asserts no panic (fails before the fix, passes after).go build ./...,go vet ./cmd/...and the new test pass locally.