Pin swift-build to a fixed revision - #14
Merged
Merged
Conversation
swift-build was floating on main, so any upstream commit could silently change build behavior between local dev and CI, or between CI runs, with no diff in this repo. Pin to 7f96ee0e8aa8a35fe84f3e80932eb9e456356d10 for reproducible builds. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
butterbearbear
approved these changes
Aug 5, 2026
| ], | ||
| dependencies: [ | ||
| .package(url: "https://github.com/swiftlang/swift-build.git", branch: "main"), | ||
| .package(url: "https://github.com/swiftlang/swift-build.git", revision: "7f96ee0e8aa8a35fe84f3e80932eb9e456356d10"), |
Contributor
There was a problem hiding this comment.
Appreciate the pin for the direct dependency! Its transitive deps still track main though, so a clean resolve can still drift with no diff here. CI already keys the cache on Package.resolved. Do we want the lockfile in this PR so local and CI resolve the same graph?
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
swift-buildwas floating onbranch: "main", so any upstream commit could change build behavior between local dev and CI, or between separate CI runs, with no diff in this repo to explain it.7f96ee0e8aa8a35fe84f3e80932eb9e456356d10via SPM'srevision:parameter.Test plan
swift package resolve— resolvesswift-buildat exactly the pinned revisionswift build— succeedsswift test— 40/40 passswiftlint lint— clean