Skip to content

fix(training): keep locked holdout nights out of movement-model teaching - #38

Merged
ng merged 1 commit into
mainfrom
fix/movement-holdout
Nov 16, 2026
Merged

ng merged 1 commit into
mainfrom
fix/movement-holdout

Conversation

@ng

@ng ng commented Nov 16, 2026

Copy link
Copy Markdown
Contributor

Summary

movement_model.py train ignored the locked holdout, so Watch motion on a locked night could teach the movement model whose features feed stage-model evaluation. fusion.py listed this as a limitation (training-17).

  • train drops Watch windows from locked nights before fitting and records holdout (rule plus locked groups) in its report. The teaching windows saved for cross-fitting therefore never include them.
  • epochs refuses a model.joblib whose teaching nights include a locked night, and fusion.py refuses movement epochs from one. search.py final already refused this case.
  • The fusion limitation line is removed.

Test plan

  • test_train_never_learns_from_locked_holdout_nights: windows on 11-12, 11-13 and 11-14 (locked) train on the first two only, and the report lists 11-14
  • test_epochs_refuse_a_model_taught_on_locked_nights
  • Full unit suite: 291 pass

🤖 Generated with Claude Code

…ing so their Watch motion never reaches stage scores

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Nov 16, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 45 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: c2ee6075-5866-4c4d-a827-9abffe281876
Commits

Reviewing files that changed from the base of the PR and between d857949 and 6927fab.

Files selected for processing: 4

  • README.md
  • scripts/fusion.py
  • scripts/movement_model.py
  • scripts/test_multimodal.py
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@ng
ng merged commit 54f9a19 into main Nov 16, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant