Repository navigation
fix(training): keep locked holdout nights out of movement-model teaching - #38
Merged
Merged
Conversation
…ing so their Watch motion never reaches stage scores Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 45 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
movement_model.py trainignored the locked holdout, so Watch motion on a locked night could teach the movement model whose features feed stage-model evaluation.fusion.pylisted this as a limitation (training-17).traindrops Watch windows from locked nights before fitting and recordsholdout(rule plus locked groups) in its report. The teaching windows saved for cross-fitting therefore never include them.epochsrefuses a model.joblib whose teaching nights include a locked night, andfusion.pyrefuses movement epochs from one.search.py finalalready refused this case.Test plan
test_train_never_learns_from_locked_holdout_nights: windows on 11-12, 11-13 and 11-14 (locked) train on the first two only, and the report lists 11-14test_epochs_refuse_a_model_taught_on_locked_nights🤖 Generated with Claude Code