-
Notifications
You must be signed in to change notification settings - Fork 687
feat(types): add data_table Block Kit block #2638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
56815fb
feat(types): add data_table Block Kit block
zimeg e2e26ff
fix(types): correct data_table max row count to 201 (200 data rows)
zimeg 66d420c
refactor(types): inline DataTableCell union into DataTableBlock.rows
zimeg 6ca2d46
docs(types): re-sync DataTableBlock JSDoc to docs + refine changeset
zimeg bfd83d3
docs(types): match page_size description to docs verbatim
zimeg 5f47f4b
refactor(types): order RawNumberElement before RawTextElement alphabe…
zimeg 449525e
docs(types): trim DataTableBlock.rows @description to the essentials
zimeg d6fca16
docs(types): match DataTableBlock.rows @description to the docs verbatim
zimeg 377813d
docs(types): simplify RawNumberElement descriptions
zimeg 3c3194e
Merge branch 'main' into chore/block-kit-data-table
zimeg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@slack/types": minor | ||
| --- | ||
|
|
||
| feat: add the [`data_table`](https://docs.slack.dev/reference/block-kit/blocks/data-table-block) Block Kit block type (`DataTableBlock`) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -173,6 +173,24 @@ export interface MrkdwnElement { | |
| verbatim?: boolean; | ||
| } | ||
|
|
||
| /** | ||
| * @description Defines an object containing a numeric value. | ||
| */ | ||
| export interface RawNumberElement { | ||
| /** | ||
| * @description The formatting to use for this numeric object. | ||
| */ | ||
| type: 'raw_number'; | ||
| /** | ||
| * @description The numeric value. | ||
| */ | ||
| value: number; | ||
| /** | ||
| * @description The text used to display the value. The minimum length is 1 character. | ||
| */ | ||
| text: string; | ||
| } | ||
|
Comment on lines
+179
to
+192
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. working great! |
||
|
|
||
| /** | ||
| * @description Defines an object containing some text. | ||
| * @see {@link https://docs.slack.dev/reference/block-kit/composition-objects/text-object Text object reference}. | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📣 note: This addresses part of #2689 but not for the table block itself!