fix: Require signatures for ssl_check request verification#1495
Open
homanp wants to merge 1 commit intoslackapi:mainfrom
Open
fix: Require signatures for ssl_check request verification#1495homanp wants to merge 1 commit intoslackapi:mainfrom
homanp wants to merge 1 commit intoslackapi:mainfrom
Conversation
|
Thanks for the contribution! Before we can merge this, we need @homanp to sign the Salesforce Inc. Contributor License Agreement. |
Author
|
CLA was signed but not showing up here. |
Author
|
@WilliamBergamin found this as well, not sure if this was "by-design" or not but worth taking a look. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RequestVerificationfrom skipping HMAC validation solely because a form body containsssl_check=1Why
When
ssl_check_enabled=False, the SSL-check middleware does not interceptssl_check=1requests. Request verification still needs to authenticate those HTTP requests before they can reach normal middleware or slash command listeners.Fixes #1494.
Testing
./scripts/run_tests.sh "tests/slack_bolt/middleware/request_verification/test_request_verification.py tests/slack_bolt_async/middleware/request_verification/test_request_verification.py tests/scenario_tests/test_slash_command.py tests/scenario_tests_async/test_slash_command.py tests/adapter_tests/wsgi/test_wsgi_http.py"./scripts/lint.sh --no-install./scripts/run_mypy.sh --no-install