feat(popover): position with CSS anchor positioning - #3614
Draft
jpzwarte wants to merge 3 commits into
Draft
Conversation
Replace the floating-ui based positioning with CSS anchor positioning. The browser now keeps the popover in place and flips it to the opposite side when there is not enough room, so the per-frame repositioning loop is gone. The `position` property is reflected as an attribute so all twelve positions can be styled from CSS, and the offset, arrow padding and viewport margin moved from static JS properties to the `--_offset`, `--_arrow-padding` and `--_viewport-margin` custom properties. Room for the arrow is reserved next to the anchor, on top of the offset. The popover also anchors itself to the element that invoked it, either via `popovertarget` or via the `source` passed to `showPopover()`/`togglePopover()`, and the anchor can now be set up entirely from CSS with `anchor-name` / `position-anchor`. Infotip uses that to anchor its popover to the trigger button in its own shadow root. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: 43f86a8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
🕸 Preview deploys |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3602
Replace the floating-ui based positioning with CSS anchor positioning. The browser now keeps the popover in place and flips it to the opposite side when there is not enough room, so the per-frame repositioning loop is gone.
The
positionproperty is reflected as an attribute so all twelve positions can be styled from CSS, and the offset, arrow padding and viewport margin moved from static JS properties to the--_offset,--_arrow-paddingand--_viewport-margincustom properties. Room for the arrow is reserved next to the anchor, on top of the offset.The popover also anchors itself to the element that invoked it, either via
popovertargetor via thesourcepassed toshowPopover()/togglePopover(), and the anchor can now be set up entirely from CSS withanchor-name/position-anchor. Infotip uses that to anchor its popover to the trigger button in its own shadow root.Supersedes #3603, which GitHub closed when the branch was renamed from
feat/3602-popover-refactoringtofeature/3602-popover-refactoring.