fix(toggle-group): use group aria role by default - #3595
Open
michal-sanoma wants to merge 2 commits into
Open
Conversation
🦋 Changeset detectedLatest commit: 1a522df The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
🕸 Preview deploys |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates toggle-group accessibility semantics while preserving explicit roles.
Changes:
- Defaults toggle groups to
role="group". - Preserves roles supplied during connection.
- Adds regression tests and a patch changeset.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
toggle-group.ts |
Updates default ARIA role behavior. |
toggle-group.spec.ts |
Tests default and explicit roles. |
.changeset/bumpy-teeth-begin.md |
Documents the patch. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
a11ymiko
marked this pull request as ready for review
August 14, 2026 09:16
a11ymiko
requested review from
Diaan,
a11ymiko,
anna-lach and
jpzwarte
as code owners
August 14, 2026 09:16
a11ymiko
approved these changes
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sl-toggle-groupfromregiontogrouprole="toolbar"Why
role="region"exposes the toggle group as a landmark, which is intended for important page sections. A toggle group is a set of related controls, sorole="group"better communicates its purpose to assistive technologiesBEFORE
AFTER